Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor homeassistant.util.slugify to homeassistant.util.string.slugify #60878

Closed
wants to merge 1 commit into from
Closed

Refactor homeassistant.util.slugify to homeassistant.util.string.slugify #60878

wants to merge 1 commit into from

Conversation

marvin-w
Copy link
Contributor

@marvin-w marvin-w commented Dec 2, 2021

Proposed change

Currently, the __init__ of the util module has third party dependencies, thus we can not move the Platform StrEnum to homeassistant.const due to dependency errors during setup.

Original Platform PR: #60857
Revert Platform PR with error message: #60875

Note: This has to be repeated for:

  • homeassistant.util.Throttle - uses the dt module that also has 3rd party deps
  • homeassistant.util.repr_helper - uses the dt module that also has 3rd party deps

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob
Copy link
Member

balloob commented Dec 2, 2021

Although I applaud this change, I think that the impact is too big on custom components and we can't make this change without being backwards compatible.

A quicker approach for StrEnum is to move that from util to a new homeassistant.backports

@marvin-w
Copy link
Contributor Author

marvin-w commented Dec 2, 2021

Although I applaud this change, I think that the impact is too big on custom components and we can't make this change without being backwards compatible.

A quicker approach for StrEnum is to move that from util to a new homeassistant.backports

Good point. I like your idea - I'll close this then. Should I open another PR for the move to homeassistant.backports?

@marvin-w marvin-w closed this Dec 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants