-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped version of wirelesstagpy to 0.8.0 #60125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run python3 -m script.hassfest
from the project root to get all requirements updated.
(venv) bookPro-236:home-assistant sam$ python3 -m script.hassfest Integrations: 1012 (venv) bookPro-236:home-assistant sam$ git st Here is nothing to commit after the command run. What I did wrong? |
I have to admit that the overall process is a nightmare and eats my time insanely. |
You did nothing wrong, I was just completely wrong in my comment (🙏 Sorry about that) It is :( |
I did run python3 -m script.gen_requirements_all before creating this PR. (venv) bookPro-236:home-assistant sam$ python3 -m script.gen_requirements_all |
ok - my investigation has shown that run of python3 -m script.gen_requirements_all which I did before creating PR, has created a record in requirements_test_all.txt for wirelesstagpy which in return failed check at CI. Maybe it is only my artificial case - my component does not have any tests yet inside HA (while tested on 100% of code lines of wirelesstagpy in own repo - see it there, but mandatory python3 -m script.gen_requirements_all which is actually forced by commit script as well just does not allow me to pass CI now... |
As I mentioned yesterday, my change ad4a6ce fixed broken CI checks. |
@sergeymaysak Please have patience. Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sergeymaysak 👍
Proposed change
Bumped version of wirelesstagpy to 0.8.0
git compare: sergeymaysak/wirelesstagpy@0.5.0...0.8.0
release notes: https://github.com/sergeymaysak/wirelesstagpy/releases/
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: