Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version of wirelesstagpy to 0.8.0 #60125

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

sergeymaysak
Copy link
Contributor

Proposed change

Bumped version of wirelesstagpy to 0.8.0
git compare: sergeymaysak/wirelesstagpy@0.5.0...0.8.0
release notes: https://github.com/sergeymaysak/wirelesstagpy/releases/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 22, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run python3 -m script.hassfest from the project root to get all requirements updated.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 22, 2021
@sergeymaysak
Copy link
Contributor Author

Please run python3 -m script.hassfest from the project root to get all requirements updated.

(venv) bookPro-236:home-assistant sam$ python3 -m script.hassfest
Warning: homeassistant/components/dyson/init.py missing, skipping directory. If this is your development environment, you can safely delete this folder.
Validating codeowners... done in 0.00s
Validating config_flow... done in 0.11s
Validating dependencies... done in 10.73s
Validating dhcp... done in 0.00s
Validating json... done in 0.00s
Validating manifest... done in 0.05s
Validating mqtt... done in 0.00s
Validating requirements... done in 0.02s
Validating services... done in 3.24s
Validating ssdp... done in 0.00s
Validating translations... done in 1.64s
Validating usb... done in 0.00s
Validating zeroconf... done in 0.00s
Validating coverage... done in 0.05s
Validating mypy_config... done in 0.01s

Integrations: 1012
Invalid integrations: 0

(venv) bookPro-236:home-assistant sam$ git st
On branch bump_0.8.0
nothing to commit, working tree clean

Here is nothing to commit after the command run. What I did wrong?

@sergeymaysak
Copy link
Contributor Author

I have to admit that the overall process is a nightmare and eats my time insanely.

@frenck
Copy link
Member

frenck commented Nov 22, 2021

Here is nothing to commit after the command run. What I did wrong?

You did nothing wrong, I was just completely wrong in my comment (🙏 Sorry about that)

It is python3 -m script.gen_requirements_all, not hassfest...

:(

@sergeymaysak
Copy link
Contributor Author

  • python3 -m script.gen_requirements_all

I did run python3 -m script.gen_requirements_all before creating this PR.
Here is what I have now after it:

(venv) bookPro-236:home-assistant sam$ python3 -m script.gen_requirements_all
Warning: homeassistant/components/dyson/init.py missing, skipping directory. If this is your development environment, you can safely delete this folder.
(venv) bookPro-236:home-assistant sam$ git st
On branch bump_0.8.0
nothing to commit, working tree clean

@sergeymaysak
Copy link
Contributor Author

ok - my investigation has shown that run of python3 -m script.gen_requirements_all which I did before creating PR, has created a record in requirements_test_all.txt for wirelesstagpy which in return failed check at CI. Maybe it is only my artificial case - my component does not have any tests yet inside HA (while tested on 100% of code lines of wirelesstagpy in own repo - see it there, but mandatory python3 -m script.gen_requirements_all which is actually forced by commit script as well just does not allow me to pass CI now...

@sergeymaysak sergeymaysak requested a review from frenck November 22, 2021 21:10
@sergeymaysak
Copy link
Contributor Author

As I mentioned yesterday, my change ad4a6ce fixed broken CI checks.
May I kindly ask to be reviewed?

@frenck
Copy link
Member

frenck commented Nov 23, 2021

@sergeymaysak Please have patience. Thanks 👍

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 23, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sergeymaysak 👍

@frenck frenck merged commit 73d4445 into home-assistant:dev Nov 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed dependency integration: wirelesstag small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants