Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libav.mpegts to stream logging filter #58937

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

uvjustin
Copy link
Contributor

@uvjustin uvjustin commented Nov 2, 2021

Proposed change

#57616 changed the logging behavior in stream to allow all messages but suppress them unless the stream logger itself is at DEBUG. To achieve this a filter is applied to each child namespace, but it appears libav.mpegts should be added to this list as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hunterjm, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@uvjustin
Copy link
Contributor Author

uvjustin commented Nov 2, 2021

We can also consider setting the log level of libav.mpegts to ERROR as we did for libav.mp4, as these warnings don't seem to add much information.

@allenporter allenporter added this to the 2021.11.0 milestone Nov 2, 2021
@allenporter allenporter merged commit f73c734 into home-assistant:dev Nov 2, 2021
balloob pushed a commit that referenced this pull request Nov 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2021
@uvjustin uvjustin deleted the change-log-level-stream branch November 7, 2021 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lot of stream warnings
5 participants