-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCKROBO_S6_PURE to supported vacuums for xiaomi_miio #58901
Conversation
Upstream pr: rytilahti/python-miio#1172 This PR does not need to be merged for this to work. Temp copy paste the constant until there is a new release of the lib. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
So, which ones are we going to add more? Can we add them at once instead of doing multiple beta fixes? :) |
I add models as folks report them and unfortunately folks have been reporting 1 by 1. I was not expecting that there would be so many supported models that have never been added to the list of supported models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We can think about there's a better way for next release. But for now we should just add the needed models to the list, I think. |
Breaking change
Proposed change
Upstream pr: rytilahti/python-miio#1172
The upstream PR does not need to be merged for this to work.
Temp copy paste the constant until there is a new release of the lib.
Reported: #58550 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: