Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROCKROBO_S6_PURE to supported vacuums for xiaomi_miio #58901

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Add ROCKROBO_S6_PURE to supported vacuums for xiaomi_miio #58901

merged 1 commit into from
Nov 2, 2021

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Nov 1, 2021

Breaking change

Proposed change

Upstream pr: rytilahti/python-miio#1172
The upstream PR does not need to be merged for this to work.
Temp copy paste the constant until there is a new release of the lib.

Reported: #58550 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Upstream pr: rytilahti/python-miio#1172
This PR does not need to be merged for this to work.
Temp copy paste the constant until there is a new release of the lib.

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@OGKevin OGKevin changed the title Add ROCKROBO_S6_PURE to support vacuums for xiaomi_miio. Add ROCKROBO_S6_PURE to supported vacuums for xiaomi_miio. Nov 1, 2021
@OGKevin OGKevin marked this pull request as ready for review November 1, 2021 16:30
@frenck
Copy link
Member

frenck commented Nov 1, 2021

So, which ones are we going to add more? Can we add them at once instead of doing multiple beta fixes? :)

@OGKevin
Copy link
Contributor Author

OGKevin commented Nov 1, 2021

I add models as folks report them and unfortunately folks have been reporting 1 by 1. I was not expecting that there would be so many supported models that have never been added to the list of supported models.
If this is becoming annoying, the code can be altered to assume all models work and don't have a mop instead.
Or this PR can remain open to collect more models.

@MartinHjelmare MartinHjelmare changed the title Add ROCKROBO_S6_PURE to supported vacuums for xiaomi_miio. Add ROCKROBO_S6_PURE to supported vacuums for xiaomi_miio Nov 1, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2021.11.0 milestone Nov 1, 2021
@MartinHjelmare
Copy link
Member

We can think about there's a better way for next release. But for now we should just add the needed models to the list, I think.

@frenck frenck merged commit 9d7786f into home-assistant:dev Nov 2, 2021
@OGKevin OGKevin deleted the add-roborock-s6-pure branch November 2, 2021 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while setting up xiaomi_miio platform for vacuum
8 participants