-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models #58591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models #58591
Conversation
#58550 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
|
Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
|
@MartinHjelmare are |
|
We can disable pylint |
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A codeowner should approve too.
* Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models. #58550 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * disable pylint for todo Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Minor refactor Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
* Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models. home-assistant#58550 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * disable pylint for todo Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Minor refactor Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Proposed change
S5_MAX is not added to the list of supported vacuum models for xiaomi_miio.
A temporary constant has been created once rytilahti/python-miio#1157 is included in a release.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: