Skip to content

Conversation

@OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Oct 28, 2021

Proposed change

S5_MAX is not added to the list of supported vacuum models for xiaomi_miio.

A temporary constant has been created once rytilahti/python-miio#1157 is included in a release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

#58550

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models. Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models Oct 28, 2021
@OGKevin
Copy link
Contributor Author

OGKevin commented Oct 28, 2021

@MartinHjelmare are TODO comments not allowed? What do you suggest I do instead? The constant in HA is a temp one 🤔

@MartinHjelmare
Copy link
Member

We can disable pylint fixme for that line.

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@OGKevin OGKevin marked this pull request as ready for review October 28, 2021 09:48
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

A codeowner should approve too.

@frenck frenck added this to the 2021.11.0 milestone Oct 28, 2021
@rytilahti rytilahti merged commit 05353f8 into home-assistant:dev Oct 28, 2021
@OGKevin OGKevin deleted the 58550-add-s5-max-to-vacuum-models branch October 28, 2021 19:17
balloob pushed a commit that referenced this pull request Oct 29, 2021
* Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models.

#58550

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>

* disable pylint for todo

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>

* Minor refactor

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
natekspencer pushed a commit to natekspencer/home-assistant-core that referenced this pull request Oct 29, 2021
* Add ROCKROBO_S5_MAX to xiaomi_miio vacuum models.

home-assistant#58550

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>

* disable pylint for todo

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>

* Minor refactor

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while setting up xiaomi_miio platform for vacuum

8 participants