Convert config.components to a set #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change but a minor one - it is not a variable that was only managed by bootstrap. A set implements the same |
andrey-git
reviewed
Feb 9, 2017
| @@ -276,7 +276,6 @@ def setup(hass, config): | |||
| # Stops server when Homeassistant is shutting down | |||
| hass.bus.listen_once( | |||
| EVENT_HOMEASSISTANT_STOP, hass.data[DATA_HOMEMATIC].stop) | |||
| hass.config.components.append(DOMAIN) | |||
There was a problem hiding this comment.
Was this removed on purpose?
There was a problem hiding this comment.
Yeah, it's the responsibility of bootstrap to do this. Not sure how it ended up here
andrey-git
approved these changes
Feb 9, 2017
|
Looks good 🐬 |
robbiet480
added a commit
to robbiet480/home-assistant
that referenced
this pull request
Feb 13, 2017
pvizeli
pushed a commit
that referenced
this pull request
Feb 13, 2017
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Convert config.components to a set from a list, as each component can only be loaded once.