Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittests for FFmpeg and spliting binary sensor #5659

Merged
merged 4 commits into from
Jan 31, 2017
Merged

Add unittests for FFmpeg and spliting binary sensor #5659

merged 4 commits into from
Jan 31, 2017

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jan 30, 2017 •
edited by fabaff
Loading

Description:

  • Add unittest for all ffmpeg stuff (exclude camera)
  • Move service for process controlling to component
  • split ffmpeg binary sensor into ffmpeg_motion and ffmpeg_noise

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1924

@mention-bot
Copy link

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @HydrelioxGitHub, @xarnze and @mjg59 to be potential reviewers.

@pvizeli pvizeli mentioned this pull request Jan 30, 2017
Merged
@balloob balloob merged commit 88d9d78 into home-assistant:dev Jan 31, 2017
Ordep pushed a commit to Ordep/home-assistant that referenced this pull request Feb 9, 2017
@pvizeli
Add unittests for FFmpeg and spliting binary sensor (home-assistant#5659
c483f52 
)

* Spliting ffmpeg binary sensor and move service to component.

* unittests for component

* add unittest for binary_sensor

* exclude camera for tests
@home-assistant home-assistant locked and limited conversation to collaborators May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change cla-signed integration: ffmpeg_motion integration: ffmpeg_noise integration: ffmpeg new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pvizeli @mention-bot @balloob @homeassistant