Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry and backoff strategy for requirements install #56580

Merged
merged 7 commits into from
Sep 26, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 23, 2021

Proposed change

  • Retry requirements install twice after one failure

  • After failures only retry after the next config check

Closes #56570

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- Retry requirements install twice after one failure

- After failures wait 24 hours or after the next config check to retry
bdraco and others added 3 commits September 26, 2021 12:24
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco bdraco marked this pull request as draft September 26, 2021 19:43
@bdraco
Copy link
Member Author

bdraco commented Sep 26, 2021

Retest didn't pass, but I may have messed up the merge into my integration branch.

Testing again.

@bdraco bdraco marked this pull request as ready for review September 26, 2021 19:46
@bdraco
Copy link
Member Author

bdraco commented Sep 26, 2021

It is all good. Clean retest passed

@bdraco bdraco merged commit f268227 into home-assistant:dev Sep 26, 2021
@bdraco bdraco deleted the requirements_memory branch September 26, 2021 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements installs do not retry transient failures or backoff on unrecoverable failures
3 participants