Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zwave_js discovery log message more descriptive #55432

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Aug 30, 2021

Proposed change

From #55381 it's clear that the log message can be confusing to a user because they are not familiar with the value ID format. With this change, we explicitly call out the device name and node ID to make it easier for users to troubleshoot.

Given that this log message will be introduced in 2021.9 this should get added to the release

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@raman325 raman325 requested a review from a team as a code owner August 30, 2021 02:14
@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@raman325 raman325 linked an issue Aug 30, 2021 that may be closed by this pull request
@raman325 raman325 added this to the 2021.9.0 milestone Aug 30, 2021
@balloob balloob merged commit ebc2a01 into home-assistant:dev Aug 30, 2021
@raman325 raman325 deleted the zwave_js_log branch August 30, 2021 04:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2021.9.0 beta: Z-Wave JS discovery value skipped
4 participants