Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device_class - qnap drive_temp sensor #55409

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Aug 29, 2021

Proposed change

The device_class needs to be the forth item in the list.

self._attr_device_class = variable_info[3]

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cdce8p cdce8p added this to the 2021.9.0 milestone Aug 29, 2021
@probot-home-assistant
Copy link

Hey there @colinodell, mind taking a look at this pull request as it has been labeled with an integration (qnap) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cdce8p cdce8p mentioned this pull request Aug 29, 2021
13 tasks
@balloob balloob merged commit be04d7b into home-assistant:dev Aug 30, 2021
@cdce8p cdce8p deleted the fix-qnap-device_class branch August 30, 2021 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants