Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONVIF open connection fix #55363

Merged
merged 1 commit into from
Aug 28, 2021
Merged

ONVIF open connection fix #55363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/components/onvif/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ async def async_setup(self) -> bool:
err,
)
self.available = False
await self.device.close()
except Fault as err:
LOGGER.error(
"Couldn't connect to camera '%s', please verify "
Expand Down
6 changes: 1 addition & 5 deletions homeassistant/components/onvif/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
"domain": "onvif",
"name": "ONVIF",
"documentation": "https://www.home-assistant.io/integrations/onvif",
"requirements": [
"onvif-zeep-async==1.0.0",
"WSDiscovery==2.0.0",
"zeep[async]==4.0.0"
],
"requirements": ["onvif-zeep-async==1.2.0", "WSDiscovery==2.0.0"],
"dependencies": ["ffmpeg"],
"codeowners": ["@hunterjm"],
"config_flow": true,
Expand Down
5 changes: 1 addition & 4 deletions requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,7 +1100,7 @@ ondilo==0.2.0
onkyo-eiscp==1.2.7

# homeassistant.components.onvif
onvif-zeep-async==1.0.0
onvif-zeep-async==1.2.0

# homeassistant.components.opengarage
open-garage==0.1.5
Expand Down Expand Up @@ -2449,9 +2449,6 @@ youless-api==0.12
# homeassistant.components.media_extractor
youtube_dl==2021.04.26

# homeassistant.components.onvif
zeep[async]==4.0.0

# homeassistant.components.zengge
zengge==0.2

Expand Down
5 changes: 1 addition & 4 deletions requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ omnilogic==0.4.5
ondilo==0.2.0

# homeassistant.components.onvif
onvif-zeep-async==1.0.0
onvif-zeep-async==1.2.0

# homeassistant.components.openerz
openerz-api==0.1.0
Expand Down Expand Up @@ -1372,9 +1372,6 @@ yeelight==0.7.4
# homeassistant.components.youless
youless-api==0.12

# homeassistant.components.onvif
zeep[async]==4.0.0

# homeassistant.components.zeroconf
zeroconf==0.36.0

Expand Down