Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SolarEdge statistics; missing device_class #53720

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 29, 2021

Proposed change

The new Energy stuff for 2021.8 wasn't working with SolarEdge.
Apparently, it was missing the device_class 😓

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit 7c98fc9 into dev Jul 29, 2021
@balloob balloob deleted the frenck-2021-2071 branch July 29, 2021 19:34

from homeassistant.components.sensor import SensorEntityDescription
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, I'd try to keep the sensor integration imports in the sensor platform.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? We do these things all the time, e.g., in constants files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constant files are only for constants that need to be shared between more than one module in the integration. Platform specific names are better to keep within each platform. It's nice to keep the import branching as clean as possible.

Copy link
Member Author

@frenck frenck Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree on that. I'd like to move as much out of the platforms as possible.

And honestly, we do this all the time, for example, look at all the coordinator files.

Putting this in the constant file is ugly too as it is not a constant, but it is defined there by most integrations, which is just as bad. Leaving it in sensor, means sensor is important const, and const is importing sensor; which is circular.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coordinator module here has clean import branches. It's only the const.py and models.py that have unclean imports since they import from the sensor integration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I'm afraid I'm not able to get on the same page with this.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants