Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with telegram_bot #53690

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Fix problem with telegram_bot #53690

merged 1 commit into from
Jul 29, 2021

Conversation

Andrew55529
Copy link
Contributor

@Andrew55529 Andrew55529 commented Jul 29, 2021

fixing an error when checking for the presence of chat_id in the allowed list

Breaking change

The data from the telegram server comes in a slightly different form than it was before or was calculated like this.

Proposed change

You can look at the issue and see that the chat data comes in a different way. I changed the piece so that everything fits

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Fixed a problem with adding only the chat id
@homeassistant
Copy link
Contributor

Hi @Andrew55529,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Andrew55529 Andrew55529 changed the title Update telegram_bot/__init__.py Fix problem with telegram_bot Jul 29, 2021
@frenck frenck added this to the 2021.8.0 milestone Jul 29, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Andrew55529 👍

@frenck frenck merged commit 09947d1 into home-assistant:dev Jul 29, 2021
balloob pushed a commit that referenced this pull request Jul 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The problem with the telegram bot
4 participants