Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only disable a device if all associated config entries are disabled #53681

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jul 29, 2021

Breaking change

Proposed change

Only disable a device if all associated config entries are disabled

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2021.8.0 milestone Jul 29, 2021
@Kane610 Kane610 requested a review from a team as a code owner July 29, 2021 09:56
@balloob
Copy link
Member

balloob commented Jul 29, 2021

Nice catch.

@balloob balloob merged commit c6213b3 into home-assistant:dev Jul 29, 2021
@Kane610 Kane610 deleted the device_registry-consider_all_integrations_before_disabling_device branch July 29, 2021 20:43
@Kane610
Copy link
Member Author

Kane610 commented Jul 29, 2021

Thanks @balloob 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devices constructed of multiple integrations are not loaded when one is disabled.
3 participants