Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exception with Guardian paired sensor coordinators #53663

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 28, 2021

Proposed change

Guardian was maintaining a rather unwieldly dict of DataUpdateCoordinator objects: most keys contained a single coordinator, but one key (related to paired sensor status) contained a dict of coordinator objects. This previously went unnoticed because, until recently, the Guardian integration was not strongly typed.

Valve controller entities were looking at their aggregated coordinators to determine their available property; the presence of a dict could throw an unhandled exception. This PR fixes things by storing paired sensor coordinators separately from the other coordinators.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 2021.8.0 milestone Jul 28, 2021
@bachya bachya self-assigned this Jul 28, 2021
@balloob balloob merged commit c04671a into home-assistant:dev Jul 29, 2021
@bdraco
Copy link
Member

bdraco commented Jul 29, 2021

Confirmed fixed 👍

@bachya bachya deleted the fix-53651 branch July 29, 2021 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback will setting up guardian on 2021.8b0
4 participants