Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script release #5345

Merged
merged 1 commit into from
Jan 15, 2017
Merged

Fix script release #5345

merged 1 commit into from
Jan 15, 2017

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 15, 2017

Description:
The release script was broken by #5079

This fixes it.

@mention-bot
Copy link

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @michaelarnauts to be a potential reviewer.

@balloob balloob merged commit 82b84f4 into dev Jan 15, 2017
@balloob balloob deleted the fix-script-release branch January 15, 2017 17:33
@michaelarnauts
Copy link
Contributor

Oops, does a command fail then? set -e makes sure that the script stops when a command returns an error code, making it less likely to miss something that went wrong...

@balloob
Copy link
Member Author

balloob commented Jan 17, 2017

Yeah, line 17 checks if a certain text not occurs with grep.

balloob added a commit that referenced this pull request Jan 17, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Apr 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants