-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-configuration possibilities for Synology DSM #53285
Re-configuration possibilities for Synology DSM #53285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment above
will have a look until end of this week 👍 |
08f6b29
to
8001b6b
Compare
I did some testing and this works as expected 👍 This seems like an existing issue, but from a security perspective, I don't think we should send back the existing password to the UI when reconfiguring. The password field should start off as blank. That's probably better addressed in #54298 |
Proposed change
With this when adding a new configuration, it is checked if there is an already existing configuration entry (identified by serial number) than this will be proper updated with new given configuration and reloaded, instead of creating a new entry.
Furthermore, when via SSDP an as new supposed NAS is detected, but an corresponding configuration entry (again identified by serial number) is found, than the existing entry will be updated (only host field)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: