Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-configuration possibilities for Synology DSM #53285

Merged
merged 7 commits into from
Aug 28, 2021

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jul 21, 2021

Proposed change

With this when adding a new configuration, it is checked if there is an already existing configuration entry (identified by serial number) than this will be proper updated with new given configuration and reloaded, instead of creating a new entry.
Furthermore, when via SSDP an as new supposed NAS is detected, but an corresponding configuration entry (again identified by serial number) is found, than the existing entry will be updated (only host field)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 21, 2021
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment above

@bdraco bdraco removed the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
@mib1185
Copy link
Contributor Author

mib1185 commented Aug 25, 2021

will have a look until end of this week 👍

@mib1185 mib1185 force-pushed the synology_dsm-re-configuration-flow branch from 08f6b29 to 8001b6b Compare August 27, 2021 18:24
@mib1185 mib1185 requested a review from Quentame as a code owner August 27, 2021 18:24
@mib1185 mib1185 requested a review from bdraco August 27, 2021 18:24
@mib1185 mib1185 requested a review from bdraco August 27, 2021 19:08
@mib1185 mib1185 requested a review from bdraco August 27, 2021 19:10
@bdraco
Copy link
Member

bdraco commented Aug 27, 2021

I did some testing and this works as expected 👍

This seems like an existing issue, but from a security perspective, I don't think we should send back the existing password to the UI when reconfiguring. The password field should start off as blank. That's probably better addressed in #54298

@bdraco bdraco merged commit 13cc671 into home-assistant:dev Aug 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
@mib1185 mib1185 deleted the synology_dsm-re-configuration-flow branch November 1, 2021 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synology_DSM integration does not allow changing essential configs like the username and password
4 participants