Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix group reload #5292

Merged
merged 4 commits into from
Jan 13, 2017
Merged

Bugfix group reload #5292

merged 4 commits into from
Jan 13, 2017

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jan 12, 2017 •
edited
Loading

Description:

After 5 hour bug hunting I found 2 bugs. Now should group work 🎉

  • We had luck that the old sync version remove groups in right order. Now with async we have no choise and I think we can not know in which order the group entity need to remove that the change listener not make a update and re create it on statemachine. I ignor now all remove entity by group state change listener and we need not known the right order or remove the entity.

So I need a 🍺

@pvizeli pvizeli added this to the 0.36 milestone Jan 12, 2017
@mention-bot
Copy link

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @partofthething, @balloob and @postlund to be potential reviewers.

balloob
balloob reviewed Jan 13, 2017
View reviewed changes
homeassistant/components/group.py
@@ -404,6 +404,9 @@ def _state_changed_listener(self, entity_id, old_state, new_state):

This method must be run in the event loop.
"""
# remove
if new_state is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. Removing a state can trigger the group state to change. I think that instead we should check if the group is stopped or not to decide if we have to proceed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think also after I have sleeping that I can better fix them.

homeassistant/helpers/entity_component.py
self._async_unsub_polling = async_track_time_interval(
self.component.hass, self._update_entity_states, self.scan_interval
)
if self._async_unsub_polling is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, it's always none because if it's not none the previous if statement returns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I wrong here.

@pvizeli pvizeli changed the title Bugfix group / hit update Bugfix group reload Jan 13, 2017
@pvizeli
Copy link
Member Author

pvizeli commented Jan 13, 2017

The new fix will check if group exists in statemachine. It also now a coro to protect he for shedule a update. In some case it will execute the update after we remove it...

@pvizeli
Copy link
Member Author

pvizeli commented Jan 13, 2017

I make a small optimaze with don't check statemachine every time, now I check the unsub from state change after I move this on top of async_remove.

@balloob balloob merged commit baa8e53 into home-assistant:dev Jan 13, 2017
@Danielhiversen Danielhiversen mentioned this pull request Jan 13, 2017
Closed
@thundergreen
Copy link

Will this be in new release tomorrow? :)

nordlead2005 added a commit to nordlead2005/home-assistant that referenced this pull request Jan 14, 2017
@nordlead2005
Revert "Bugfix camera streams (home-assistant#5306)"
2ee8c44 
This reverts commit 4b43537.

Revert "Version bump for kodi dependency (home-assistant#5307)"

This reverts commit 6abad6b.

Revert "Add HMWIOSwitch to sensor, binary (home-assistant#5304)"

This reverts commit 2c3f55a.

Revert "Remove GTFS default name & string change"

This reverts commit 6000c59.

Revert "Update pyhomematic 1.19 & small cleanups (home-assistant#5299)"

This reverts commit a30711f.

Revert "[sensor] Add Dublin bus RTPI sensor (home-assistant#5257)"

This reverts commit 1219ca3.

Revert "Bugfix group reload (home-assistant#5292)"

This reverts commit baa8e53.

Revert "Support for TrackR device trackers (home-assistant#5010)"

This reverts commit f7a1d63.

Revert "Bump pywemo version."

This reverts commit dc937cc.

Revert "Upgrade to voluptuous to 0.9.3 (home-assistant#5288)"

This reverts commit d12decc.

Revert "Upgrade distro to 1.0.2 (home-assistant#5291)"

This reverts commit 64800fd.

Revert "Don't build Adafruit_BBIO - doesn't work on all platforms. (home-assistant#5281)"

This reverts commit 9a3c0c8.

Revert "Convert flic to synchronous platform. (home-assistant#5276)"

This reverts commit eb9b95c.

Revert "Upgrade to aiohttp 1.2 (home-assistant#4964)"

This reverts commit e68e29e.

Revert "Fix TCP sensor to correctly use value_template (home-assistant#5211)"

This reverts commit 1cf9ae5.

Revert "Cleanup language support on TTS (home-assistant#5255)"

This reverts commit 3f3a3bc.

Revert "Add last triggered to script (home-assistant#5261)"

This reverts commit 467cb18.

Revert "Bump flux_led version and make use of PyPi package (home-assistant#5267)"

This reverts commit 34a9fb0.

Revert "Add support for NAD receivers (home-assistant#5191)"

This reverts commit 3b59e16.

Revert "Bugfix async device_tracker see callback (home-assistant#5259)"

This reverts commit 71fddd2.

Revert "Use SHA hash to make token harder to guess (home-assistant#5258)"

This reverts commit 922308b.
balloob pushed a commit that referenced this pull request Jan 27, 2017
@nordlead2005 @balloob
Added forecast support to DarkSky (#5264)
8379941 
* Added forecast support to DarkSky

	modified:   homeassistant/components/sensor/darksky.py
	modified:   tests/components/sensor/test_darksky.py

* Fix async_volume_up / async_volume_down (#5249)

async_volume_up / async_volume_down should be async versions of
volume_up / volume_down, not a async version of the default variants of
volume_up / volume_down.

The previous code always called into the mediaplayers set_volume_level,
and never into volume_up / volume_down.

Signed-off-by: Anton Lundin <glance@acc.umu.se>

* adding a default icon "blind" to a PowerView blinds scene. (#5210)

* adding a default icon "blind" to a PowerView blinds scene.

* Adding icon property to define blind icon. Removed it from the state attributes dict.

* fixing lint error

* Added forecast support to DarkSky

	modified:   homeassistant/components/sensor/darksky.py
	modified:   tests/components/sensor/test_darksky.py

* Use SHA hash to make token harder to guess (#5258)

* Use SHA hash to make token harder to guess

Use hashlib SHA256 to encode object id instead of using it directly.

* Cache access token

Instead of generating a token on the fly cache it in the constructor.

* Fix lint

* Bugfix async device_tracker see callback (#5259)

* Add support for NAD receivers (#5191)

* Add support for NAD receivers

* remove self.update() in various methods

* remove setting attributes in various methods

* Change import to hass style

* Updated Config Validation, extended daily forecast to all supported types

* Fix style errors from previous commit, fix test since adding daily for all supported types

* Removed temperature from daily as it isn't supported

* Added forecast support to DarkSky

	modified:   homeassistant/components/sensor/darksky.py
	modified:   tests/components/sensor/test_darksky.py

* Updated Config Validation, extended daily forecast to all supported types

* Fix style errors from previous commit, fix test since adding daily for all supported types

* Removed temperature from daily as it isn't supported

* Revert "Bugfix camera streams (#5306)"

This reverts commit 4b43537.

Revert "Version bump for kodi dependency (#5307)"

This reverts commit 6abad6b.

Revert "Add HMWIOSwitch to sensor, binary (#5304)"

This reverts commit 2c3f55a.

Revert "Remove GTFS default name & string change"

This reverts commit 6000c59.

Revert "Update pyhomematic 1.19 & small cleanups (#5299)"

This reverts commit a30711f.

Revert "[sensor] Add Dublin bus RTPI sensor (#5257)"

This reverts commit 1219ca3.

Revert "Bugfix group reload (#5292)"

This reverts commit baa8e53.

Revert "Support for TrackR device trackers (#5010)"

This reverts commit f7a1d63.

Revert "Bump pywemo version."

This reverts commit dc937cc.

Revert "Upgrade to voluptuous to 0.9.3 (#5288)"

This reverts commit d12decc.

Revert "Upgrade distro to 1.0.2 (#5291)"

This reverts commit 64800fd.

Revert "Don't build Adafruit_BBIO - doesn't work on all platforms. (#5281)"

This reverts commit 9a3c0c8.

Revert "Convert flic to synchronous platform. (#5276)"

This reverts commit eb9b95c.

Revert "Upgrade to aiohttp 1.2 (#4964)"

This reverts commit e68e29e.

Revert "Fix TCP sensor to correctly use value_template (#5211)"

This reverts commit 1cf9ae5.

Revert "Cleanup language support on TTS (#5255)"

This reverts commit 3f3a3bc.

Revert "Add last triggered to script (#5261)"

This reverts commit 467cb18.

Revert "Bump flux_led version and make use of PyPi package (#5267)"

This reverts commit 34a9fb0.

Revert "Add support for NAD receivers (#5191)"

This reverts commit 3b59e16.

Revert "Bugfix async device_tracker see callback (#5259)"

This reverts commit 71fddd2.

Revert "Use SHA hash to make token harder to guess (#5258)"

This reverts commit 922308b.

* Revert "Revert "Bugfix camera streams (#5306)""

This reverts commit 2ee8c44.

* Update darksky.py
@home-assistant home-assistant locked and limited conversation to collaborators Apr 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob left review comments

Assignees

@balloob balloob

Labels
async bug component core
Projects
None yet
Milestone
0.36
Development

Successfully merging this pull request may close these issues.
5 participants
@pvizeli @mention-bot @thundergreen @balloob @balloobbot