Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASUS.gpio / not working with new GCC #51662

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Remove ASUS.gpio / not working with new GCC #51662

merged 1 commit into from
Jun 9, 2021

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 9, 2021

Breaking change

Ditch support of ASUS.gpio python lib - Today with the new GPIO interface of the kernel, it should not break a lot.

Proposed change

This ASUS python library is written in a very low-quality style and this can't be compiled anymore with GCC.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Jun 9, 2021
@frenck frenck merged commit c21895f into dev Jun 9, 2021
@frenck frenck deleted the tinker-ditch-gpio branch June 9, 2021 11:33
thomasgermain pushed a commit to thomasgermain/home-assistant that referenced this pull request Jun 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants