Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adext dependency #51315

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

ajschmidt8
Copy link
Contributor

Proposed change

This PR updates the adext dependency to 0.4.2, which updates the underlying alarmdecoder dependency to 1.13.11.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery
Copy link
Contributor

Thanks, @ajschmidt8 👍

@emontnemery emontnemery merged commit 0e0da26 into home-assistant:dev Jun 1, 2021
@frenck
Copy link
Member

frenck commented Jun 1, 2021

Should this have been tagged for the beta?

@ajschmidt8 ajschmidt8 deleted the update-adext branch June 1, 2021 13:56
@ajschmidt8
Copy link
Contributor Author

Should this have been tagged for the beta?

@frenck, not sure if this question is for me or not, but I don't know the answer.

@frenck frenck added this to the 2021.6.0 milestone Jun 1, 2021
balloob pushed a commit that referenced this pull request Jun 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants