Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pyroon to 0.0.37 #51164

Merged
merged 1 commit into from
May 27, 2021
Merged

Bump pyroon to 0.0.37 #51164

merged 1 commit into from
May 27, 2021

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented May 27, 2021

Proposed change

This PR bumps the pyroon library to 0.0.37. This fixes a reported bug in play_media.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The library changes are only related to reproducing and fixing the bug linked below.

Details of library changes are here: pavoni/pyroon@0.0.36...0.0.37

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pavoni pavoni mentioned this pull request May 27, 2021
Closed
janiversen
janiversen approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinHjelmare MartinHjelmare merged commit 02ac9a7 into dev May 27, 2021
@MartinHjelmare MartinHjelmare deleted the bump_pyroon branch May 27, 2021 19:01
@MartinHjelmare
Copy link
Member

Should we tag this for 2021.6.0?

@pavoni
Copy link
Contributor Author

pavoni commented May 27, 2021

Yes please, if it’s not too late.

@frenck frenck added this to the 2021.6.0 milestone May 27, 2021
frenck pushed a commit that referenced this pull request May 28, 2021
@pavoni @frenck
Bump pyroon to 0.0.37 (#51164)
e86e70f
eavanvalkenburg pushed a commit to eavanvalkenburg/home-assistant that referenced this pull request May 28, 2021
@pavoni @eavanvalkenburg
Bump pyroon to 0.0.37 (home-assistant#51164)
48497f6
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump integration: roon small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.6.0
Development

Successfully merging this pull request may close these issues.

Easy Fix for a bug related to TIDAL library playback in the Roon Integration
5 participants
@pavoni @MartinHjelmare @janiversen @frenck @homeassistant