Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jinja2.contextfilter decorator renamed to pass_context #51007

Merged
merged 2 commits into from
May 24, 2021

Conversation

mdz
Copy link
Contributor

@mdz mdz commented May 23, 2021

Proposed change

Bump jinja 2 from >= 2.11.3 to >= 3.0.1
jinja2 release notes: https://jinja.palletsprojects.com/en/3.0.x/changes/#version-3-0-1

Fix this warning:

homeassistant/helpers/template.py:1319: DeprecationWarning: 'contextfilter' is renamed to 'pass_context', the old name will be removed in Jinja 3.1.

Since this was added in Jinja 3.0.1, bump the dependency accordingly. This is the same version we actually get in practice when all of the dependencies are installed, so this doesn't change the version in use in practice.

$ docker run homeassistant/home-assistant:stable pip3 show jinja2
Name: Jinja2
Version: 3.0.1
Summary: A very fast and expressive template engine.
Home-page: https://palletsprojects.com/p/jinja/
Author: Armin Ronacher
Author-email: armin.ronacher@active-4.com
License: BSD-3-Clause
Location: /usr/local/lib/python3.8/site-packages
Requires: MarkupSafe
Required-by: Sphinx, Flask, homeassistant

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels May 23, 2021
@mdz mdz marked this pull request as draft May 23, 2021 19:29
@mdz mdz marked this pull request as ready for review May 23, 2021 21:22
@emontnemery
Copy link
Contributor

It's correct that a fresh install will get Jinja2 3.0.1 since we don't pin the version:

jinja2>=2.11.3

@emontnemery emontnemery merged commit e964c60 into home-assistant:dev May 24, 2021
@mdz mdz deleted the jinja2-contextfilter-pass_context branch May 25, 2021 15:22
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants