Skip to content

Conversation

@rytilahti
Copy link
Member

@rytilahti rytilahti commented May 5, 2021

Breaking change

Proposed change

Bumps python-miio to the newest release, most prominently:

  • Improves support for Rockrobo s6&s7 vacuums
  • Fixes a regression for Xiaomi Air Purifiers' AQI reporting
  • Fixes Zigbee lights when used with gateway devices

Full changelog at https://github.com/rytilahti/python-miio/releases/tag/0.5.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @syssi, @starkillerOG, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@rytilahti rytilahti marked this pull request as ready for review May 5, 2021 21:11
@rytilahti rytilahti added this to the 2021.5.1 milestone May 5, 2021
@balloob balloob merged commit 0ed31b0 into home-assistant:dev May 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vaccum Roboter S7 from roborock are not detected as an new entity Got an exception while sending command get_bright Xiaomi Air Purifier AQI Unknown

5 participants