add offline tts using pico #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 19, 2016
| finally: | ||
| os.remove(fname) | ||
| if data: | ||
| return ("wav", data) |
houndci-bot
reviewed
Dec 19, 2016
|
|
||
| class PicoProvider(Provider): | ||
| """pico speech api provider.""" | ||
|
|
|
Looks good. Finish all task they are open in your PR and fix lint |
balloob
reviewed
Dec 26, 2016
| with open(fname, 'rb') as voice: | ||
| data = voice.read() | ||
| except OSError: | ||
| return |
There was a problem hiding this comment.
You need to return (None, None) to indicate nothing got returned.
houndci-bot
reviewed
Dec 27, 2016
| with open(fname, 'rb') as voice: | ||
| data = voice.read() | ||
| except OSError: | ||
| _LOGGER.error("Error trying to read %s",fname) |
|
Please look at you Checklist and fix ie. all lint error and add a docu. |
houndci-bot
reviewed
Jan 3, 2017
| """Load TTS using pico2wave.""" | ||
| if language not in SUPPORT_LANGUAGES: | ||
| language = self.language | ||
| with tempfile.NamedTemporaryFile(suffix='.wav', delete=False) as tempfp: |
pvizeli
approved these changes
Jan 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
add offline tts using pico
it requires pico2wave to be install on the system, on debian like
sudo apt install libttspico-utilsPull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1706
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass