Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ELKM1 entity service schema #50020

Merged
merged 1 commit into from
May 3, 2021
Merged

Fix ELKM1 entity service schema #50020

merged 1 commit into from
May 3, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented May 3, 2021

Proposed change

Fixes the entity service schema for the ELKM1 integration to ensure it works with service targets.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @gwww, @bdraco, mind taking a look at this pull request as its been labeled with an integration (elkm1) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@gwww
Copy link
Contributor

gwww commented May 3, 2021

Looks ok to me. Did something actually break or is this to bring the code in line with another change... or something else?

Thanks!

@frenck
Copy link
Member Author

frenck commented May 3, 2021

@gwww In the previous format, it would break service calls that use the target format, using e.g., an area or device.

@balloob balloob merged commit a2d12f9 into dev May 3, 2021
@balloob balloob deleted the frenck-2021-1370 branch May 3, 2021 16:40
balloob pushed a commit that referenced this pull request May 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants