-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pylint to 2.8.0 #49637
Update pylint to 2.8.0 #49637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the upgrade 👍
Looks like change to with
for subprocesses is causing a problem with the timeouts in the test
tests/components/command_line/test_notify.py
is failing locally with this change
Already working on it 😄 |
Think I got it now. @bdraco Would you mind taking a quick look at the last two commits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Thanks!
Proposed change
Update
pylint
andastroid
to their latest versions.Changelog: http://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-8-0
Full diff: pylint-dev/pylint@pylint-2.7.4...pylint-2.8.0
New features
consider-using-min-builtin
,consider-using-max-builtin
,consider-using-with
loop
argument for a lot ofasyncio
functionstyping
, with the checkersdeprecated-typing-alias
,consider-using-alias
,consider-alternative-union-syntax
. These allow us to easily check for deprecated typing aliases (PEP 585) and old union syntax (PEP 604). Most of the resulting changes have already been merged with Update typing syntax #49480Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: