Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint to 2.8.0 #49637

Merged
merged 9 commits into from
Apr 25, 2021
Merged

Update pylint to 2.8.0 #49637

merged 9 commits into from
Apr 25, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 24, 2021

Proposed change

Update pylint and astroid to their latest versions.
Changelog: http://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-8-0
Full diff: pylint-dev/pylint@pylint-2.7.4...pylint-2.8.0

New features

  • New checkers: consider-using-min-builtin, consider-using-max-builtin, consider-using-with
  • Improved checker for deprecated function arguments. E.g., the loop argument for a lot of asyncio functions
  • New optional extension: typing, with the checkers deprecated-typing-alias, consider-using-alias, consider-alternative-union-syntax. These allow us to easily check for deprecated typing aliases (PEP 585) and old union syntax (PEP 604). Most of the resulting changes have already been merged with Update typing syntax #49480

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the upgrade 👍

Looks like change to with for subprocesses is causing a problem with the timeouts in the test

tests/components/command_line/test_notify.py is failing locally with this change

@cdce8p
Copy link
Member Author

cdce8p commented Apr 24, 2021

Thanks for doing the upgrade 👍

Looks like change to with for subprocesses is causing a problem with the timeouts in the test

tests/components/command_line/test_notify.py is failing locally with this change

Already working on it 😄

@cdce8p cdce8p requested a review from bdraco April 25, 2021 00:11
@cdce8p
Copy link
Member Author

cdce8p commented Apr 25, 2021

Looks like change to with for subprocesses is causing a problem with the timeouts in the test
tests/components/command_line/test_notify.py is failing locally with this change

Already working on it 😄

Think I got it now. @bdraco Would you mind taking a quick look at the last two commits?

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Thanks!

@bdraco bdraco merged commit f1d48dd into home-assistant:dev Apr 25, 2021
@cdce8p cdce8p deleted the update-pylint branch April 25, 2021 00:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants