Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AlarmDecoder dependency #46841

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Conversation

ajschmidt8
Copy link
Contributor

@ajschmidt8 ajschmidt8 commented Feb 21, 2021

Proposed change

This PR updates the adext dependency to v0.4.1, which ultimately updates the underlying alarmdecoder package. The updates in the alarmdecoder package should help fix #36298.

Changelog: ajschmidt8/adext@v0.3.0...v0.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Feb 21, 2021

v0.3.0...v0.4.0#diff-60f61ab7a8

It looks like this is a pre-release version of the pypi package?

@ajschmidt8
Copy link
Contributor Author

v0.3.0...v0.4.0#diff-60f61ab7a8

It looks like this is a pre-release version of the pypi package?

@bdraco, that's correct. A long time ago, someone tried bumping the alarmdecoder package in Home Assistant from 1.13.2 to 1.13.9 (#31385), but 1.13.9 had an issue that broke the HA integration. This issue was ultimately resolved in nutechsoftware/alarmdecoder#56 (and tested by myself and others), but the fix has not yet been published by the AlarmDecoder team themselves. Additionally, there's a new problem, #36298, with the current alarmdecoder version used by the integration that requires a commit in AlarmDecoder's dev branch that also has not been published.

The AlarmDecoder team has been pretty unresponsive to most of my PRs and release inquiries (1, 2, 3). Since #36298 has been open for ~10 months now and I haven't heard from the AlarmDecoder folks, I published a new package, alarmdecoder2, from my fork which includes all the changes up to this commit on their dev branch.

In comparing that commit to their latest 1.13.9 release, it seems that the majority (~93%) of the changes are fixes related to #31385 and #36298, while the others are minor dependency updates.

Sorry for the novel. Ultimately it seems like the AlarmDecoder team is AWOL and therefore I published my own fork in order to fix some of these outstanding HA integration issues. I plan on switching back to their official package when/if they ever release a new update.

One final note is that this version bump also loosens some pinned dependencies that @MartinHjelmare described in ajschmidt8/adext#3.

@bdraco
Copy link
Member

bdraco commented Feb 21, 2021

That seems like a mess. Have you tried more traditional contact methods?

Nu Tech Software Solutions, Inc.
Phone: 503-443-2000
Fax: 503-968-1877
Email: general@support.nutech.com

@ajschmidt8
Copy link
Contributor Author

That seems like a mess. Have you tried more traditional contact methods?

Nu Tech Software Solutions, Inc.
Phone: 503-443-2000
Fax: 503-968-1877
Email: general@support.nutech.com

yup, I agree. I'll try reaching out via email later today.

@bdraco
Copy link
Member

bdraco commented Feb 24, 2021

@ajschmidt8 any luck?

@ajschmidt8
Copy link
Contributor Author

@ajschmidt8 any luck?

yes, sorry forgot to report back. I got a response and was given write permissions on the repo to help maintain it. hoping to have an official update out this weekend.

@ajschmidt8 ajschmidt8 marked this pull request as draft February 24, 2021 13:34
@bdraco
Copy link
Member

bdraco commented Feb 24, 2021

@ajschmidt8 any luck?

yes, sorry forgot to report back. I got a response and was given write permissions on the repo to help maintain it. hoping to have an official update out this weekend.

That is great news. 👍

@ajschmidt8 ajschmidt8 marked this pull request as ready for review February 28, 2021 21:12
@ajschmidt8
Copy link
Contributor Author

@bdraco, I updated this PR to reflect the new packages that I've just released:

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Should we tag this for .3?

@bdraco bdraco added this to the 2021.3.0 milestone Feb 28, 2021
@ajschmidt8
Copy link
Contributor Author

Thanks. Should we tag this for .3?

@bdraco, works for me.

@bdraco bdraco merged commit b8c8fe0 into home-assistant:dev Feb 28, 2021
@ajschmidt8 ajschmidt8 deleted the update-adext branch February 28, 2021 23:24
pvizeli pushed a commit that referenced this pull request Mar 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlarmDecoder zones alternating on and off forever upon HA start if multiple zones are open
4 participants