-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AlarmDecoder dependency #46841
Conversation
It looks like this is a pre-release version of the pypi package? |
@bdraco, that's correct. A long time ago, someone tried bumping the The AlarmDecoder team has been pretty unresponsive to most of my PRs and release inquiries (1, 2, 3). Since #36298 has been open for ~10 months now and I haven't heard from the AlarmDecoder folks, I published a new package, alarmdecoder2, from my fork which includes all the changes up to this commit on their In comparing that commit to their latest 1.13.9 release, it seems that the majority (~93%) of the changes are fixes related to #31385 and #36298, while the others are minor dependency updates. Sorry for the novel. Ultimately it seems like the AlarmDecoder team is AWOL and therefore I published my own fork in order to fix some of these outstanding HA integration issues. I plan on switching back to their official package when/if they ever release a new update. One final note is that this version bump also loosens some pinned dependencies that @MartinHjelmare described in ajschmidt8/adext#3. |
That seems like a mess. Have you tried more traditional contact methods? Nu Tech Software Solutions, Inc. |
yup, I agree. I'll try reaching out via email later today. |
@ajschmidt8 any luck? |
yes, sorry forgot to report back. I got a response and was given write permissions on the repo to help maintain it. hoping to have an official update out this weekend. |
That is great news. 👍 |
45f1d66
to
aea1bd6
Compare
@bdraco, I updated this PR to reflect the new packages that I've just released: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Should we tag this for .3?
@bdraco, works for me. |
Proposed change
This PR updates the
adext
dependency to v0.4.1, which ultimately updates the underlying alarmdecoder package. The updates in thealarmdecoder
package should help fix #36298.Changelog: ajschmidt8/adext@v0.3.0...v0.4.1
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: