Skip to content

Conversation

@farmio
Copy link
Contributor

@farmio farmio commented Feb 7, 2021

Proposed change

Enable auto_reconnect for auto-discovered connections

Without this reconnection to KNX bus is not done anymore when connection is lost once.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title KNX: enable auto_reconnect for auto-discovered connections Enable KNX auto_reconnect for auto-discovered connections Feb 8, 2021
@MartinHjelmare MartinHjelmare merged commit e7ca0ff into home-assistant:dev Feb 8, 2021
@farmio
Copy link
Contributor Author

farmio commented Feb 8, 2021

@MartinHjelmare can you please Tag this for the Next 2021.2 dot-release?

@MartinHjelmare MartinHjelmare added this to the 2021.2.2 milestone Feb 8, 2021
@MartinHjelmare
Copy link
Member

Tagged.

@farmio farmio deleted the knx-auto-reconnect branch February 8, 2021 10:53
@balloob balloob mentioned this pull request Feb 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants