Skip to content

Conversation

@marcelveldt
Copy link
Member

Breaking change

Proposed change

We get a lot of issue reports of confused users because their entities are shown as unavailable, due to the fact that we render an entity as unavailable when the ZWaveValue.value is missing.
I've had a little discussion about this with @AlCalzone and he said we should never assume that the value is there upfront, it may be added later when the device reports its status or is (partially) reinterviewed. It might even come only once the user has done an action, such as toggling a switch/light. Hence this proposal to not render the entity unavailable but instead allow the user to use the entity. The incorrect state due to the missing value will correct itself over time, maybe even if the user toggles the device from within HA.

I'm still a bit doubting if we should leave the unavailable state for sensors as their state is kind of pointless without data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Additional information

Fixes several issues mentioned on discord. I'll collect any issues created on the GH issue tracker.

Fixes zwave-js/zwave-js#1609

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration (zwave_js) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my limited understanding

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 242ff04 into home-assistant:dev Feb 6, 2021
@marcelveldt
Copy link
Member Author

should it be tagged for next patch release or is is strictly not a bug?

@MartinHjelmare MartinHjelmare added this to the 2021.2.2 milestone Feb 6, 2021
@MartinHjelmare
Copy link
Member

I think we can tag it.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qubino ZMNHJD1 not working

5 participants