Skip to content

Conversation

@raman325
Copy link
Contributor

@raman325 raman325 commented Feb 5, 2021

Proposed change

  • Move name generation into helper method
  • Handle empty values for input parameters into name
  • If we can't find the value in the list of states, just return the value as the state

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration (zwave_js) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@raman325 raman325 changed the title Only include property key name in zwave_js Notification CC sensor name if it exists Refactor how we generate zwave_js entity names Feb 5, 2021
@raman325 raman325 changed the title Refactor how we generate zwave_js entity names Various fixes for Notification CC sensors and binary sensors Feb 5, 2021
@raman325 raman325 changed the title Various fixes for Notification CC sensors and binary sensors Various fixes for zwave_js Notification CC sensors and binary sensors Feb 5, 2021
@MartinHjelmare MartinHjelmare changed the title Various fixes for zwave_js Notification CC sensors and binary sensors Fix zwave_js Notification CC sensors and binary sensors Feb 5, 2021
@raman325
Copy link
Contributor Author

raman325 commented Feb 5, 2021

should we include this in the next minor release?

@MartinHjelmare
Copy link
Member

Are there no issues reported for this?

@raman325
Copy link
Contributor Author

raman325 commented Feb 5, 2021

at least one, let me review and link as needed

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare added this to the 2021.2.2 milestone Feb 5, 2021
@MartinHjelmare MartinHjelmare merged commit 33169cf into home-assistant:dev Feb 5, 2021
@raman325 raman325 deleted the notification_sensor_name branch February 5, 2021 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Z-Wave JS First Alert Smoke Alarm - alarm_type and alarm_level unknown Z-Wave JS missing alarm_type and alarm_level on lock

6 participants