Skip to content

Conversation

@cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 5, 2021

Proposed change

While testing a development version of pylint, I got a deprecation warning:

Warning: homeassistant/components/zwave/light.py:178:47: W1505: Using deprecated method isAlive() (deprecated-method)

After some research I found that it should be is_alive() and the current isAlive() was deprecated in 3.8 and removed in 3.9. Unfortunately I don't have any Zwave lights to test it but it looks fine.

For reference: https://bugs.python.org/issue37804

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cdce8p cdce8p added this to the 2021.2.2 milestone Feb 5, 2021
@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration (zwave) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 55f9d98 into home-assistant:dev Feb 5, 2021
@cdce8p cdce8p deleted the fix-zwave branch February 5, 2021 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants