-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Fix foscam to work again with non-admin accounts and make RTSP port configurable again #45975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MartinHjelmare
merged 9 commits into
home-assistant:dev
from
skgsergio:fix-foscam-with-non-admin-users
Feb 5, 2021
Merged
Fix foscam to work again with non-admin accounts and make RTSP port configurable again #45975
MartinHjelmare
merged 9 commits into
home-assistant:dev
from
skgsergio:fix-foscam-with-non-admin-users
Feb 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foscam cameras require admin account for getting the MAC address, requiring an admin account in the integration is not desirable as an operator one is good enough (and a good practice). Old entries using the MAC address as unique_id are migrated to the new unique_id format so everything is consistent. Also fixed unhandled invalid responses from the camera in the config flow process.
Contributor
Author
|
Both bug fixes are important and both changes the configuration so in order to ship them quicker I've decided to keep them in one single PR as both require entry migration. |
MartinHjelmare
requested changes
Feb 5, 2021
MartinHjelmare
approved these changes
Feb 5, 2021
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The integration is currently broken for users using non-admin accounts and for some models that incorrectly reports its RTSP port wrongly (sorry! 😓).
Foscam cameras require admin account for getting the MAC address, requiring an admin account in the integration is not desirable as an operator one is good enough (and a good practice).
Old entries using the MAC address as unique_id are migrated to the new unique_id format so everything is consistent.
Related to this issue I've found that motion detection setting is also restricted to admin accounts and was throwing an error that was not helpful so I've also added proper error messages to those cases.
Also fixed unhandled invalid responses from the camera in the config flow process.
Also the RTSP port is reported incorrectly in some models which causes stream not to work, so I made RTSP port configurable again (and importing it correctly from the old config).
So to recap:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: