Neato Fixes #4490
Merged
Neato Fixes #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbokongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jabesq to be a potential reviewer. |
balloob
reviewed
Nov 20, 2016
| @@ -100,6 +104,7 @@ def turn_on(self, **kwargs): | |||
| self.robot.start_cleaning() | |||
| elif self.type == SWITCH_TYPE_SCHEDULE: | |||
| self.robot.enable_schedule() | |||
| self.schedule_update_ha_state() | |||
There was a problem hiding this comment.
you don't have to schedule an update, Home Assistant will do that because this device has should_poll == True
There was a problem hiding this comment.
Does that mean update() will be called after turn_off() is done?
balloob
reviewed
Nov 20, 2016
| @@ -109,3 +114,4 @@ def turn_off(self, **kwargs): | |||
| self.robot.send_to_base() | |||
| elif self.type == SWITCH_TYPE_SCHEDULE: | |||
| self.robot.disable_schedule() | |||
| self.schedule_update_ha_state() | |||
There was a problem hiding this comment.
If this call is slow, it's probably because of the time.sleep(1)
balloob
pushed a commit
that referenced
this pull request
Nov 22, 2016
* Fix, switch state. Move constants to hub * Responsiveness * Whitespace * Delay was not needed as commands does not return until done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Neato Clean switch did not update correctly on spot- or manual cleaning and was slow in responsiveness.
Also moved the Constants to the hub.