-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyroon discovery #44811
Merged
Merged
Pyroon discovery #44811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jan 4, 2021
balloob
reviewed
Jan 4, 2021
balloob
reviewed
Jan 4, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
I’d like to open another PR to improve the roon play_media command, are you guys ok for me to do that while this is still open? |
MartinHjelmare
approved these changes
Jan 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
MartinHjelmare
approved these changes
Jan 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds discovery to the roon integration. There were previously issues with discovery in the roon library - which stopped it working effectively. These have now been resolved - and so this PR switches to use discovery. If discovery fails to find any servers the code still allows users to specify a host.
Type of change
Additional information
Roon discovery uses a unique ID found on roon core server - and so this PR uses this in place of the IP address that was used previously to nam the players (the IP address is not needed or available if discovery is used). This was suggested by @MartinHjelmare when he reviewed the initial PR - but at the time the library didn't have a suitable id available. Using a unique id allows some simplification of the config_flow - since it is no longer possible to specify duplicate addresses. There is a little code to keep backwards compatibility of player names - so HA users do not need to re-create their integrations - and players are not renamed.
As such this is not a breaking change
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: