Fixing 'Unknown' status for Nest Protect devices #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 20, 2016
| @@ -195,15 +195,15 @@ def update(self): | |||
| if self.variable == 'battery_level': | |||
| self._state = getattr(self.device, self.variable) | |||
| else: | |||
| self._state = 'Unknown' | |||
|
|
|||
|
Confirm this corrects the Nest Protect issue for me. Thanks! |
balloob
pushed a commit
that referenced
this pull request
Nov 22, 2016
* Fixing 'Unknown' status for Nest Protect devices * Fixing bad formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: After the refactor next protect sensors broke because of the switch from return statements to the use of self._state. This fixes that.
Related issue (if applicable): fixes #4293
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass