Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack "invalid_blocks_format" bug #43875

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Dec 3, 2020

Proposed change

Through a (presumably recent) API change, Slack no longer allows an empty dict to be passed to the blocks parameter. This PR fixes that issue. Also, while in there, it reduces some unnecessary code and adds me as the codeowner for the integration (thought I did that previously).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 1.0.0 milestone Dec 3, 2020
@bachya bachya self-assigned this Dec 3, 2020
@dels78
Copy link

dels78 commented Dec 3, 2020

@bachya thank you for the fix, I was going nuts without my notifications!

I have replaced the notify.py file with yours and it is back on track. will update officially when the fix is pushed!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 69a438e into home-assistant:dev Dec 3, 2020
@bachya bachya deleted the slack-blocks branch December 4, 2020 02:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack throws error with simple message
5 participants