Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Launch Library 2 #42723

Merged
merged 4 commits into from
Nov 5, 2020
Merged

Move to Launch Library 2 #42723

merged 4 commits into from
Nov 5, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 1, 2020

Breaking change

Proposed change

Technically this is a dependency upgrade, but it's also a bug-fix (since the current API is no longer working), and some refactor.

I did not use GitHub releases when I made the current version of the library, so a version diff is not possible.
But I tracked down the commit that triggered the Travis build for 0.2.0.

1.0.0 Release notes

1.0.0 Release notes

Changes

This is a breaking release, it has moved to Launch Library 2, see the updated example.py file for a reference.

Changes between 0.2.0 and 1.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MattXcz
Copy link

MattXcz commented Nov 4, 2020

Awesome ! Thanks @ludeeus

@MartinHjelmare
Copy link
Member

Please exclude the new const module from coverage in .coveragerc.

@MartinHjelmare MartinHjelmare merged commit a199d7a into dev Nov 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the launch_library2 branch November 5, 2020 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rocket launch_library requires update to new api
4 participants