Use common strings in life360 config flow #42375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
code-quality
integration: life360
small-pr
allenporter
approved these changes
Oct 28, 2020
springstan
commented
Oct 28, 2020
|
Tests for the config flow are missing. 🙈 |
Working on it asap 😅 |
|
That would be great! We can merge here when the build passes. |
|
Actually I cannot find any tests for this integration 😆 |
|
Yeah, that was what I meant. |
Oh sorry misunderstood what you meant by missing. |
|
Yeah, this PR is ok. We don't need to add any tests here. |
tschamm
pushed a commit
to tschamm/core
that referenced
this pull request
Oct 29, 2020
* Use common strings for life360 config flow * Address feedback comments * Keep two space indentation * Fix indentation hopefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use common strings in life360 config flow as described in #40578
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: