Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ONVIF to Zeep 4.0/httpx #42020

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Conversation

hunterjm
Copy link
Member

Proposed change

This PR is the long-term fix for #41907 by updating the dependent library to utilize zeep[async]==4.0.0.

With the move to httpx we are also able to address the comments in #38729 by adding a get_snapshot call directly inside the parent library.

Finally, this includes changes to how we determine creation of pullpoint subscriptions, partially solving the issues raised in #41949

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

homeassistant/components/onvif/__init__.py Show resolved Hide resolved
homeassistant/components/onvif/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/onvif/camera.py Outdated Show resolved Hide resolved
@bdraco
Copy link
Member

bdraco commented Oct 19, 2020

Verified working with a doorbird 👍

@bdraco
Copy link
Member

bdraco commented Oct 19, 2020

Is the httpx AsyncClient being closed on unload ?

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question about the client being closed and this looks good to go.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reloaded, and restarted. It appears the session is being closed as no error was logged 👍

@hunterjm
Copy link
Member Author

Yeah, clients are closed inside lib on call to device.close(). They weren’t inside the config flow initially hence the additions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants