-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ONVIF to Zeep 4.0/httpx #42020
Conversation
Verified working with a doorbird 👍 |
Is the httpx AsyncClient being closed on unload ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the question about the client being closed and this looks good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reloaded, and restarted. It appears the session is being closed as no error was logged 👍
Yeah, clients are closed inside lib on call to |
Proposed change
This PR is the long-term fix for #41907 by updating the dependent library to utilize
zeep[async]==4.0.0
.With the move to
httpx
we are also able to address the comments in #38729 by adding aget_snapshot
call directly inside the parent library.Finally, this includes changes to how we determine creation of pullpoint subscriptions, partially solving the issues raised in #41949
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: