Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core GitHub URL in contributing guidelines #41083

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Use core GitHub URL in contributing guidelines #41083

merged 2 commits into from
Oct 2, 2020

Conversation

gerard33
Copy link
Contributor

@gerard33 gerard33 commented Oct 2, 2020

Proposed change

Update to use the correct Github url for Home Assistant Core.
Change https://github.com/home-assistant/home-assistant to https://github.com/home-assistant/core

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! One small comment

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Happy Hacktoberfest 🎉

@springstan springstan changed the title Update CONTRIBUTING.md Use core github url in contributing guidelines Oct 2, 2020
@frenck frenck changed the title Use core github url in contributing guidelines Use core GitHub URL in contributing guidelines Oct 2, 2020
@frenck frenck merged commit a3511a9 into home-assistant:dev Oct 2, 2020
@springstan springstan mentioned this pull request Oct 2, 2020
21 tasks
ronanmu pushed a commit to ronanmu/home-assistant that referenced this pull request Oct 3, 2020
Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants