-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable hdmi_cec component #40671
Re-enable hdmi_cec component #40671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you intend to help work on this integration going forward (since you are now a maintainer of the upstream library), please add yourself to the codeowners in manifest.json too. (Then run python3 -m script.hassfest
to update the top level CODEOWNERS file).
Otherwise, this looks good, of course.
I am not sure if this is a long-term position, I only have PyPi access to the upstream right now (no repository access), I am clarifying with the owner of |
I have repository access now, I added myself as a codeowner. P.S. Sorry if rebasing changes is discouraged, I did not find anything in the developer workflow about it. I know some places dislike them, and others require them. |
Please add a link to the changelog or github commit compare range for the version bump in the PR description. |
Done! It is just two small commits between 0.4.13 and 0.4.14. Commits in 0.4.14 since 0.4.13: |
That's not really accurate. I've added the commit compare range to the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Things got a bit out of order :/. I made the release on a branch before I realized that I did not have permissions to merge it back into maater. The branches then got merged (rebased?) out of order. I added the tags retroactively to preserve as much history as possible, but it is what it is. For the future I added a changelog and have some repository access, so there will be improved accounting of changes. |
Thanks newAM for driving this! I guess it will be in 0.116 next week or so? |
This is my first contribution to home assistant so I know as much as you do :) It seems like releases are currently on a 3 week cycle[1] so probably next week or the week after? There will be a beta before then though. |
Release is currently planned for the 7th of October. This made the cutoff
so it should be included, unless some show stopping issue is discovered
requiring it to be rolled back, which seems unlikely.
|
Proposed change
This change re-enables the
hdmi_cec
component.The component was removed in #37707 because it had a dependency on typing, which has since been resolved with the latest release of pyCEC, 0.4.14.
konikvranik/pyCEC@v0.4.13...v0.4.14
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: