Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cgtobi to sonos code owners #40204

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Add cgtobi to sonos code owners #40204

merged 2 commits into from
Sep 18, 2020

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented Sep 17, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cgtobi cgtobi requested a review from amelchio September 17, 2020 22:48
@ctalkington ctalkington changed the title Add myself to Sonos code owners Add cgtobi to sonos code owners Sep 18, 2020
@ctalkington ctalkington merged commit 689f151 into dev Sep 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the cgtobi-codeowner-sonos branch September 18, 2020 01:16
@amelchio
Copy link
Contributor

Hey @cgtobi, good luck! 😃

Feel free to tag me for reviews, especially if you touch stuff that I have been working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants