Use DEVICE_CLASS_DOOR and DEVICE_CLASS_SMOKE in various integrations #39950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
reviewed
Sep 11, 2020
| @@ -89,7 +92,7 @@ def name(self): | |||
| @property | |||
| def icon(self): | |||
| """Icon for device by its type.""" | |||
| if self._zone_type == "smoke": | |||
| if self._zone_type == DEVICE_CLASS_SMOKE: | |||
There was a problem hiding this comment.
Odd that this takes arbitrary strings for the zone type.
There was a problem hiding this comment.
The zone type is not validated as a device class string. Then we shouldn't compare with our device class constants either.
bdraco
approved these changes
Sep 11, 2020
bachya
approved these changes
Sep 11, 2020
…-device-class-smoke-door
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use DEVICE_CLASS_DOOR and DEVICE_CLASS_SMOKE in various integrations
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: