Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TensorFlow to 2.3 #39673

Merged
merged 3 commits into from
Sep 6, 2020
Merged

Upgrade TensorFlow to 2.3 #39673

merged 3 commits into from
Sep 6, 2020

Conversation

hunterjm
Copy link
Member

@hunterjm hunterjm commented Sep 5, 2020

Breaking change

Proposed change

We needed to bump tf-models-official to a version that doesn't install typing, which requires TensorFlow >=2.3. @pvizeli - How hard would it be to update the TF builder to 2.3?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@hunterjm hunterjm changed the title Bump tf-models-official to 2.3.0 Upgrade TensorFlow to 2.3 Sep 5, 2020
@frenck frenck self-assigned this Sep 5, 2020
@frenck
Copy link
Member

frenck commented Sep 5, 2020

Assigned myself, bumping Tensorflow wheels is a task on my list (as I have partly unprocessed changes from 2.2.0 still left).

@frenck
Copy link
Member

frenck commented Sep 5, 2020

Marking this as draft until the wheels are ready, to prevent accidental merging.

@frenck frenck marked this pull request as draft September 5, 2020 07:15
@hunterjm
Copy link
Member Author

hunterjm commented Sep 5, 2020

Draft is fine for now, but the integration is broken in 0.115. This should get merged before then even if wheels aren’t ready for users on a venv install.

@frenck
Copy link
Member

frenck commented Sep 5, 2020

The venv is not the part I'm worried about, people running those type of installations can handle a pip command... however, users of our container images (including Docker, Home Assistant OS and Supervised) cannot handle this change without wheels.

My goal is to ensure the wheels are up this weekend. 👍

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wheels have been build and are available.

Thanks for the PR @hunterjm 👍

@frenck frenck merged commit 3b88452 into dev Sep 6, 2020
@frenck frenck deleted the tf-models-bump branch September 6, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants