-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outdated api url in noaa_tides #39370
Conversation
Hi @jdelaney72, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
ca414e2
to
6b384ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️
Please, add your GitHub username to the manifest.json
of this integration.
For more information about "code owners", see: Architecture Decision Record 0008: Code owners.
Awesome, thanks @jdelaney72! Great first-time contribution! 👍 |
* Fix outdated dependency in noaa_tides * Catch exceptions when instantiating new Station * Add myself to codeowners
Proposed change
The external web service used by the noaa_tides platform moved its
api to a new url. The pypi package used to fetch data (py_noaa) still
points to the old/broken url. It is outdated and has been
replaced - no further development is planned.
I've updated the sensor to use the replacement package
(noaa-coops==0.1.8). The new package uses a Station class to fetch
tide data so I changed setup_platform to create a station instance
and changed the sensor's update function to use the station class
to get data.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: