-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize knx config and update xknx to 0.12.0 #39219
Conversation
Hey there @Julius2342, mind taking a look at this pull request as its been labeled with an integration ( |
Can you please restart the CI pipeline? The error was unrelated to that change (and green in the original PR (#38880)) |
Thank you @frenck! There still appears to be an error with the cached virtual environments:
|
I have no clue 🤷 Could you rebase your PR onto the latest |
@frenck This PR is just a wrapper for two other PRs that have already been reviewed ( #39189 & #38880) and merged into an intermediary branch within HA. If I rebase onto the latest dev I'm effectively rewriting the history (and thus a force push is needed - for which I do not have sufficient permission). @MartinHjelmare created the branch within HA yesterday. I could merge fast forward but since you specifically asked for a rebase I wanted to clarify first. |
1896b9a
to
f28aeaf
Compare
Rebased it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
* Refactor KNX integration to centralize configuration yaml (home-assistant#39189) * Updates for xknx 0.12.0 (home-assistant#38880)
* Refactor KNX integration to centralize configuration yaml (home-assistant#39189) * Updates for xknx 0.12.0 (home-assistant#38880)
It would be a nice addition to also allowing labels for knx includes Analogous example to the one here: knx:
tunneling:
host: '192.168.0.1'
light groups: !include knx-light-groups.yaml
light switches: !include knx-light-switches.yaml |
If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum. Merged PRs should not be used for enhancement discussion or bug reports. Thanks! |
Breaking change
This change incorporates the following pull requests that have been merged to an intermediary branch in order to be able to merge them together to dev once done.
Proposed change
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: