Fix TTS languange characters #39211
Merged
Fix TTS languange characters #39211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
small-pr
balloob
approved these changes
Aug 25, 2020
| """Set up the demo platform and call service with extend language.""" | ||
| import homeassistant.components.demo.tts as demo_tts | ||
|
|
||
| demo_tts.SUPPORT_LANGUAGES.append("en_US") |
There was a problem hiding this comment.
Won't this change to the constant remain after this test is run?
There was a problem hiding this comment.
Maybe, however, it have only a usage if you load it, otherwise it's just around
There was a problem hiding this comment.
It's bad practice to have persistent effects in tests as it might effect other (future) tests unexpectedly.
balloob
pushed a commit
that referenced
this pull request
Aug 26, 2020
Merged
weissm
pushed a commit
to weissm/core
that referenced
this pull request
Aug 28, 2020
leikoilja
pushed a commit
to leikoilja/core
that referenced
this pull request
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fix issues with using
_on language code. Make it aware for integration.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: