Hotfix for Netatmo discovery #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jabesq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @HydrelioxGitHub, @fabaff and @Jypy to be potential reviewers. |
balloobbot
reviewed
Oct 12, 2016
| try: | ||
| if CONF_MODULES in config: | ||
| # Iterate each module | ||
| for module_name, monitored_conditions in config[CONF_MODULES].items(): |
There was a problem hiding this comment.
- 80: E501 line too long (82 > 79 characters)
balloobbot
reviewed
Oct 12, 2016
| dev.append(NetAtmoSensor(data, module_name, variable)) | ||
| else: | ||
| for module_name in data.get_module_names(): | ||
| for variable in data.station_data.monitoredConditions(module_name): |
There was a problem hiding this comment.
- 80: E501 line too long (83 > 79 characters)
This should definetly fix home-assistant#2601 Signed-off-by: Hugo D. (jabesq) <jabesq@gmail.com>
jabesq
force-pushed
the
Netatmo-Hotfix
branch
from
5ed0584 to
1d5e96d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hotfix for the Netatmo discovery as it now uses by all netatmo devices (sensor, binary sensor and camera).
Related issue (if applicable): fixes #2601 and full error log seen during PR #3836
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass