-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intelligent timeout handler for setup/bootstrap #38329
Conversation
So, the timeout is now done with all supported features. Now we need just add it to HA |
Add added a cool down which allow |
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
…tant/core into setup-timeout-handler
@pvizeli I did as much testing as I could think of with this. So far everything looks good and I put it on both my houston and maui primary instances without any issues. |
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
…tant/core into setup-timeout-handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Retesting now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed on 5 production instances. No obvious issues
Proposed change
This timeout handler solve forever all issues with blocking startup setups without a hack or workaround. It's a zone/global-based timeout handler.
ToDo:
hass.data
This domain allows a clean setup and respect all kind of timeouts and raise only a timeout if a component make issues.
This needs some tweaks and optimization, all help is welcome.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: