Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aiohttp to 3.6.2 #38082

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Upgrade aiohttp to 3.6.2 #38082

merged 1 commit into from
Jul 22, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 22, 2020

Proposed change

This PR upgrades aiohttp to 3.6.2. While we had issues upgrading in the past, apparently, some things changed that made the original issues we had with this upgrade disappear.

I've not been able to reproduce the issues we had before (failing through proxy, failing Ingress).

The Supervisor (dev) has been running on my production system for over a week and a half already without an issue.

Changelog: https://docs.aiohttp.org/en/stable/changes.html#id1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added core dependency small-pr PRs with less than 30 lines. labels Jul 22, 2020
@balloob balloob merged commit b15dad8 into dev Jul 22, 2020
@balloob balloob deleted the frenck-2020-0714 branch July 22, 2020 21:56
@balloob
Copy link
Member

balloob commented Jul 22, 2020

Let's keep an eye on it, if it shows up we know where to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core dependency small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants